This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, alpha]: Fix debug/PR7055


Hello!

Attached patch fixes a problem in parse_def()/mips-tfile.c, which is
incorrectly parsing defs like '11_Is_integerIbE;' as a number. The old
code already tries to make sure that the string is only parsed as a
number if it is immidiately followed by a ';' or ',' (like '11;' or
'11,') but the logic is wrong. This is fixed by the patch.

The patch was originally created and tested against the 4.1.1 release,
and attached to the PR. I was asked to post the patch here for review,
so I ported the patch to the current trunk. Therefore the patch is
untested in its current version, and I currently don't have the means to
test it.

Note that there are two further occurences of the same problematic code
(mips-tfile.c, r143199, line 2914 and 2988), but I didn't have to modify
these to fix the original PR.

2009-01-09 Markus Schoepflin <markus.schoepflin@comsoft.de>

* gcc/mips-tfile.c (parse_def): Fix parsing of def strings
starting with digits.

I have also changed lines 2914 and 2988 in the same way (it is obvious that we are also looking for a number there) and committed the patch to 4.3 and 4.4 branch.


Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]