This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping (i386 backend, configury)
- From: jh at suse dot cz
- To: "Jakub Jelinek" <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, "Alexandre Oliva" <aoliva at redhat dot com>, "Paolo Bonzini" <bonzini at gnu dot org>, "Jan Hubicka" <jh at suse dot cz>, "Uros Bizjak" <ubizjak at gmail dot com>
- Date: Sat, 20 Dec 2008 13:42:38 +0100 (CET)
- Subject: Re: Patch ping (i386 backend, configury)
- References: <20081218080750.GU17496@tyan-ft48-01.lab.bos.redhat.com>
> Hi!
>
> [i386] http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00751.html
> P2 PR target/38488
> Richard already reviewed this, but wanted a backend person
> to review the i386 backend parts. On this patch depend a bunch
> of DSE fixes, so it is needed to fix P2 PR middle-end/31150
> as well.
The patch looks fine in general. I would break out the constant alignment
code into separate function (such as gen_constant_setmem_prologue).
Also memcpy expander needs similar adjustment?
It is possible to be more cureful here: even if known alignment+offset is
smaller than desired alignment+offset the generic prologue can be
simplified, but I am not sure it is worth the effort.
The patch is preapproved with the prologue code broken out and memcpy
updated too.
Honza
> [configury] http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00727.html
> P1 PR bootstrap/37739
> Fix powerpc*-linux 32-bit bootstrap where cc1* etc. grow
> too large for default 32-bit link if not -O1+ or -Wl,--relax
>
> Both patches have been bootstrapped/regtested several times
> on x86_64-linux, i386-linux and powerpc64-linux. Ok for trunk?
>
> Jakub
>