Re: [PATCH] Add support for Lattice Mico32

["Joseph S. Myers" <joseph at codesourcery dot com>]

I haven't checked whether you have a copyright assignment on file covering 
this port.

If the port is for uClinux the target triplet should be *-*-uclinux* not 
*-*-linux*.  Linux (with MMU and normal ELF shared libraries, not FDPIC) 
is *-*-linux-gnu* for glibc default and *-*-linux-uclibc* for uClibc 
default.  Which is this port?

Some source files have old FSF addresses.  Except for files used in libgcc 
they should have GPLv3 notices anyway, which do not include an FSF postal 
address.  Nor have notices references "GNU CC" instead of GCC for many 
years.

Is there a reason this new port is using fp-bit instead of soft-fp, which 
is faster?

You almost certainly don't need the xm-lm32.h file.  Host configuration 
has been done with autoconf for a long time and only very unusual hosts 
need such files now.  If this is uClinux it probably isn't suitable to be 
a host anyway, only a target.

This port uses the old method of configuring crt*.o files.  There is a 
transition in progress to having libgcc configuration information in the 
libgcc directory instead of carried over from the gcc directory.  For any 
area where any port has been transitioned to using the libgcc directory, 
new ports should do so - this means, at least, setting extra_parts in 
libgcc/config.host, and possibly having t-* files in libgcc saying how to 
build these files.  (I'm not sure if anything needs duplicating in the gcc 
directory, but such duplication should be kept to a minimum.)

Do not include generic comments (i.e., ones that just repeat what the 
internals manual has to say about the macro rather than saying anything 
specific to this port) on your definitions of target macros.  Such 
duplicate comments never get updated when the manual does.  There are far 
too many such comments already, often from pretty old versions of the 
manual.

-- 
Joseph S. Myers
joseph@codesourcery.com