This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Don't XFAIL 21674.cc on darwin
On Sun, Dec 14, 2008 at 09:11:44PM +0100, Paolo Bonzini wrote:
>
> > Paolo,
> > I haven't found any examples which show that xfail can be used in
> > combination with target? Are you sure that combination is valid? I think
> > we shouldn't avoid running this test on darwin since it does pass and would
> > check that the behvaior isn't regressed in some later darwin libc.
>
> grep dg-xfail-if.
>
> Paolo
How about...
Index: testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc
===================================================================
--- testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc (revision 142752)
+++ testsuite/21_strings/basic_string/element_access/wchar_t/21674.cc (working copy)
@@ -1,6 +1,6 @@
// { dg-require-debug-mode "" }
// { dg-options "-O0 -D_GLIBCXX_DEBUG" }
-// { dg-do run { xfail *-*-* } }
+// { dg-xfail-run-if "PR21674" { target { ! { *-*-darwin* } } } { "*" } { "" } }
// Copyright (C) 2005 Free Software Foundation, Inc.
//
Index: testsuite/21_strings/basic_string/element_access/char/21674.cc
===================================================================
--- testsuite/21_strings/basic_string/element_access/char/21674.cc (revision 142752)
+++ testsuite/21_strings/basic_string/element_access/char/21674.cc (working copy)
@@ -1,6 +1,6 @@
// { dg-require-debug-mode "" }
// { dg-options "-O0 -D_GLIBCXX_DEBUG" }
-// { dg-do run { xfail *-*-* } }
+// { dg-xfail-run-if "PR21674" { target { ! { *-*-darwin* } } } { "*" } { "" } }
// Copyright (C) 2005 Free Software Foundation, Inc.
//
Index: testsuite/22_locale/ctype/is/char/2.cc
===================================================================
--- testsuite/22_locale/ctype/is/char/2.cc (revision 142752)
+++ testsuite/22_locale/ctype/is/char/2.cc (working copy)
@@ -1,4 +1,4 @@
-// { dg-do run { xfail *-*-![linux]* } }
+// { dg-xfail-run-if "" { target { ! { *-*-linux* } } } { "*" } { "" } }
// { dg-require-namedlocale "" }
// Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005
Jack