This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: State of old format warning patch for Mac OS X
- From: Masaki Muranaka <monaka at monami-software dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: Stan Shebs <stan at codesourcery dot com>, gdb-patches at sourceware dot org, gcc-patches at gnu dot org
- Date: Sun, 14 Dec 2008 14:02:17 +0900
- Subject: Re: State of old format warning patch for Mac OS X
- References: <487BD56B.9040609@earthlink.net> <20080714230022.GA14011@caradoc.them.org> <E9C9ACBF-0F6C-4806-85E7-B5597E0AA286@monami-software.com> <48874D23.7050508@codesourcery.com> <20080723154029.GA16569@caradoc.them.org>
Hello,
// For GCC hackers,
// This issue is described at gdb-patches ML.
// Related mail is:
// http://sourceware.org/ml/gdb-patches/2008-07/msg00418.html
Today I inspected this issue again.
I think intl libraries and dependent sources are synchronized between gcc and src.
The direct reason of this issue is caused by -Wmissing-format-attribute.
For example, gcc/collect2.o will failed to build after you add -Wmissing-format-attribute in gcc/Makefile
same as gdb/Makefile.
An easiest fix is removing -Wmissing-format-attribute from gdb/Makefile
But I don't like removing warning detections. I think libgnuintl.h will be patched.
How do you think, Daniel and GCC hackers?
On 2008/07/24, at 0:40, Daniel Jacobowitz wrote:
> On Wed, Jul 23, 2008 at 08:24:19AM -0700, Stan Shebs wrote:
>> But since I see that it has been years since gettext has been imported,
>> I'd say to just install this patch into src/ now - it's just a one-liner
>> and if by some chance it gets missed in a hypothetical future import,
>> it's easy to re-add. I'm guessing you don't have commit access? so I'll
>> take care of it.
>
> Please check whether intl is currently in sync between gcc and src
> first; if so (I think it is), it needs to go to gcc first.
>
> --
> Daniel Jacobowitz
> CodeSourcery
>
Masaki Muranaka
Monami Software