This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto] Add timevars and propagate -v and -save-temps
- From: Diego Novillo <dnovillo at google dot com>
- To: Ollie Wild <aaw at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 30 Nov 2008 22:56:52 -0500
- Subject: Re: [lto] Add timevars and propagate -v and -save-temps
- References: <20081129172822.GA18090@google.com> <65dd6fd50811301550x552292fcg57f88e4a81e35fe0@mail.gmail.com>
On Sun, Nov 30, 2008 at 18:50, Ollie Wild <aaw@google.com> wrote:
> This only works if MAKEFLAGS is inherited from the parent make. It
> looks like you broke this mechanism in a previous change and are now
> hacking around that fact. I'm not quite sure what the issue was that
> prompted unsetting MAKEFLAGS, but maybe a better solution is to unset
> MAKEFLAGS in the test harness.
No, MAKEFLAGS was confusing the Makefile generated by the
ltrans-driver script for an unrelated reason. It would cause spurious
failures in the GCC testsuite, especially when the parent make was
running with -j N. Rafael unset it in a previous patch. My patch
just added some simple parallelism since we couldn't inherit it using
MAKEFLAGS.
Perhaps a better solution would be to determine what exactly was
confusing the Makefile generated by ltrans-driver, but I didn't
explore that. I'll see about it shortly.
Diego.