This is the mail archive of the
mailing list for the GCC project.
Re: [Patch, Fortran] PR fortran/37779: Diagnose missing RECURSIVE, part 2
- From: Tobias Burnus <burnus at net-b dot de>
- To: Daniel Kraft <d at domob dot eu>
- Cc: fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 30 Nov 2008 20:08:03 +0100
- Subject: Re: [Patch, Fortran] PR fortran/37779: Diagnose missing RECURSIVE, part 2
- References: <4931A902.firstname.lastname@example.org>
Daniel Kraft wrote:
> I did refactor and clean-up recursive-ness detection in resolve.c a
> bit, and hope I did get it all right (the ENTRY handling, too). No
> regressions on GNU/Linux-x86-32.
> Ok for trunk (4.4)? Or should we wait even with this patch for 4.5?
> I believe this is enough of a bug-fix to go in for 4.4, though.
I think that should be OK for 4.4.
I think it does not really matter but the error message text for the
following example is not quite right since "test" is not an ENTRY:
end subroutine test
Error: ENTRY 'test' at (1) cannot be called recursively, as subroutine
'test' is not RECURSIVE
As the message is still comprehensive and it is the same message as
before, I think one can leave it as is.
Thanks for the patch.