This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Fix some corner cases in get_callee_fn and aggregate_value_p


On Wed, Nov 26, 2008 at 9:36 AM, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> Hi,
>
> while reviewing the call abi patch for x86_64, I found the following
> issues. Maybe they are of some relevants as I noticed they are happening.
> The patch in get_callee_fn for allowing  check for addr being a
> FUNCTION_DECL seems to be of not much relevant here, but at least there is
> a check in front checking for
> a readonly function pointer, which verifies that TREE_CODE(addr) isn't
> already a FUNCTION_DECL.

The function.c part makes sense, but I don't see how what the tree.c
part tests for is valid - did that really happen?  Testcase?

You didn't state if/how you bootstrapped and tested this.

Richard.

> ChangeLog
>
> 2008-11-26  Kai Tietz  <kai.tietz@onevision.com>
>
>        * tree.c (get_callee_fn): Allow that CALL_EXPR points directly to
> a FUNCTION_DECL.
>        * function.c (aggregate_value_p): For call expression take
> function type itself, if there
>        is no declaration available.
>
> Is this patch ok for apply?
>
> Cheers,
> Kai
>
>
>
> |  (\_/)  This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]