This is the mail archive of the
mailing list for the GCC project.
Re: PATCH: Fix unportabilities in dg-extract-results.sh
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Rainer Orth <ro at techfak dot uni-bielefeld dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 22 Nov 2008 00:31:36 +0000 (UTC)
- Subject: Re: PATCH: Fix unportabilities in dg-extract-results.sh
- References: <18727.10160.888575.482079@manam.TechFak.Uni-Bielefeld.DE>
On Fri, 21 Nov 2008, Rainer Orth wrote:
> In the make check output on Solaris 10/x86, I noticed the following errors:
> usage: tail [+/-[n][lbc][f]] [file]
> tail [+/-[n][l][r|f]] [file]
> This is due to the use of tail -n in contrib/dg-extract-results.sh, which
> isn't portable. All over the tree, we use tail -<n> instead.
> This patch does this and also fixed a typo (two consecutive || signs).
Why do you think the use of || is a typo? Piping into a command that
doesn't take input from stdin doesn't make sense, but the command with ||
does (if there are no ^# lines in the output from the first tail command,
then use that output by rerunning the command).
Joseph S. Myers