This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto][patch] Fix case where cc1plus writes a function_decl but not the cgraph node


On Tue, Nov 18, 2008 at 11:38, Rafael Espindola <espindola@google.com> wrote:

>        (lto_symtab_set_resolution): Rename to
>        lto_symtab_set_resolution_and_file_data. Record the file_data.

Nit, the habit is to write it reversed:

		(lto_symtab_set_resolution_and_file_data): Rename
		from lto_symtab_set_resolution.

Not crucial, though.

> - symtab_decl = (struct lto_symtab_decl_def*) *slot;
> - return symtab_decl->resolution;
> +  return lto_symtab_get_symtab_def(decl)->resolution;

Space before '('.

> +struct lto_file_decl_data *
> +lto_symtab_get_file_data (tree decl)
> +{
> +  return lto_symtab_get_symtab_def(decl)->file_data;

Likewise.

OK otherwise.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]