This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libcpp+C++ PATCH] Fix -Wempty-body C++ warning (PR c++/36478)


Jakub Jelinek wrote:

> A lot of people write for (a = b; something; somethingelse) ;
> or for (a = b; something; somethingelse)/* Empty */;

Yes, but I bet a lot of them also write:

 for (a = b; something; somethingelse);

The significance of that whitespace seems very questionable to me.

> -save-temps is perhaps not 100% important, though many people will moan, but
> ccache is important for a lot of users.

The problem is that I don't think the space is significant.  And, if
it's not, then replacing an macro that expands to nothing with a space
leaves the pre-processed source ambiguous: is the space an insignificant
space provided by the user or is it a significant space resulting from
macro expansion?  We can't tell.

Maybe this just argues for reverting Mike's patch.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]