This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] [MIPS] Pass -mdsp if compiling for DSP core
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Catherine Moore <clm at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 10 Nov 2008 20:32:09 +0000
- Subject: Re: [patch] [MIPS] Pass -mdsp if compiling for DSP core
- References: <4899BCB2.3090208@codesourcery.com> <874p5ud0ah.fsf@firetop.home> <4917551D.9060500@codesourcery.com>
Catherine Moore <clm@codesourcery.com> writes:
> Hi Richard,
>
> I'm attaching an updated patch which addresses your comments. Does this version look okay to
> install? Thanks,
>
> Catherine
>
> * config.gcc (mips64vrel-*-elf*): Include the tm_file prior to vr.h.
> * config/mips/linux.h (LINUX_DRIVER_SELF_SPECS): New.
> (BASE_DRIVER_SELF_SPECS): Remove.
> (DRIVER_SELF_SPECS): New definition.
> * config/mips/elfoabi.h: (DRIVER_SELF_SPECS): Include BASE_DRIVER_SELF_SPECS.
> * config/mips/sde.h: Likewise.
> * config/mips/iris6.h: Likewise.
> * config/mips/vr.h: Likewise.
> * config/mips/mips.h (BASE_DRIVER_SELF_SPECS): New.
Looks good. For the record, the original suggestion was to include
BASE_DRIVER_SELF_SPECS in LINUX_DRIVER_SELF_SPECS rather than the
linux{,64}.h DRIVER_SELF_SPECS, whereas the patch does the latter.
I'm not sure if that was a deliberate change or not. But I'm happy
either way, so please keep it as-is.
Just one niggle:
> + /* Target-specific rules. */ \
> + BASE_DRIVER_SELF_SPECS
I found this comment a bit confusing. I assume it means "MIPS-specific",
but in this context, I think the thing to emphasis is that these are
configuration-independent. So how about:
/* Configuration-independent MIPS rules. */
OK with that change, thanks. (OK at this stage because you posted
the originaly patch before we went into regressions-only mode.)
Richard