This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] [MIPS] Pass -mdsp if compiling for DSP core

Catherine Moore <> writes:
> Hi Richard,
> I'm attaching an updated patch which addresses your comments.  Does this version look okay to 
> install?  Thanks,
> Catherine
> 	* config.gcc (mips64vrel-*-elf*): Include the tm_file prior to vr.h.
> 	* config/mips/linux.h (LINUX_DRIVER_SELF_SPECS): New.
> 	(DRIVER_SELF_SPECS): New definition.
> 	* config/mips/elfoabi.h: (DRIVER_SELF_SPECS): Include BASE_DRIVER_SELF_SPECS.
> 	* config/mips/sde.h: Likewise.
> 	* config/mips/iris6.h: Likewise.
> 	* config/mips/vr.h: Likewise.
> 	* config/mips/mips.h (BASE_DRIVER_SELF_SPECS): New.

Looks good.  For the record, the original suggestion was to include
linux{,64}.h DRIVER_SELF_SPECS, whereas the patch does the latter.
I'm not sure if that was a deliberate change or not.  But I'm happy
either way, so please keep it as-is.

Just one niggle:

> +  /* Target-specific rules.  */						\

I found this comment a bit confusing.  I assume it means "MIPS-specific",
but in this context, I think the thing to emphasis is that these are
configuration-independent.  So how about:

  /* Configuration-independent MIPS rules.  */

OK with that change, thanks.  (OK at this stage because you posted
the originaly patch before we went into regressions-only mode.)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]