Re: 4.3/4.4 PATCH: Fix Solaris/x86 bootstrap with Sun ld (PR bootstrap/33100)

[Rainer Orth <ro at techfak dot uni-bielefeld dot de>]

Ian Lance Taylor writes:

> Rainer Orth <ro@techfak.uni-bielefeld.de> writes:
> 
> > Fri Oct 10 16:27:14 2008  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>
> >
> > 	PR bootstrap/33100
> > 	* config.gcc (i[34567]86-*-solaris2*): Include i386/t-crtstuff
> > 	only with GNU ld.
> 
> I may well misunderstand, but this seems like a somewhat hacky
> workaround which avoids a bug in the linker by introducing a bug in
> the unwind information.  However, I don't have a better suggestion,

true, and I'm not really comfortable about it either.  But since no fix has
been forthcoming on the Solaris 10 side and GCC 4.2+ have been
inoperational on Solaris 10+/x86, I decided to propose it anyway.

> and it sounds like this will be fixed in later versions of Solaris.

As I suggested in the original patch submission, it should be possible to
move the inclusion of i386/t-crtstuff to libgcc/configure.ac and make it
conditional on a linker test there.  This way, only systems with broken Sun
linkers would be penalized.  I could well try that approach, since it's
certainly cleaner and doesn't break unwind information on recent Solaris 11
where we don't have to.  What do you think?

> I'll approve this patch for mainline and 4.3 branch.

What about the 4.2 branch?  As I mentioned, the patch is needed there, too,
and I've successfully bootstrapped on i386-pc-solaris2.10.  Unfortunately,
the cleaner approach outlined above isn't available here since there's no
separate libgcc with it's own configure, so I fear it's either this hack or
leave that branch broken.

Thanks.
	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University