This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: _Unwind_GetIPInfo Redux: Patch for PR target/27880


Hi,

and first many thanks for working on this issue.
> You were discussing issues about cross configuration a while back
> and config tests that do link tests when building libstdc++.
>
> GCC_CHECK_UNWIND_GETIPINFO is one of those tests and the patch
>
> 	http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00647.html
>
> is my attempt to address this issue while also fixing PR target/27880
> which is on the 4.4 serious regression list.  Do either of you have an
> opinion on the approach I have taken?  It is not ideal but I don't have
> any better ideas on how to handle it.
>   
As far as I understand the rationale and the actual implementation of
your patch I like it and consider it a big improvement compared to the
current situation.

If/when the patch will be applied, you should also change
libstdc++/configure.ac, moving GCC_CHECK_UNWIND_GETIPINFO ouside the
block if $GLIBCXX_IS_NATIVE, before it, thus run unconditionally. This
additional change is pre-approved.

Thanks again,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]