This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libjava support for AIX


On Fri, Oct 24, 2008 at 09:45:43AM +0100, Andrew Haley wrote:
> Tom Tromey wrote:
> >>>>>> "David" == David Edelsohn <dje.gcc@gmail.com> writes:
> > 
> > David> Index: classpath/native/fdlibm/fdlibm.h
> >  
> > David>  #include <config.h>
> > David>  #include <stdlib.h>
> > David> +#undef hz
> >  
> > Could you add a blank line between the #include and the #undef, and a
> > comment explaining why this is needed?  Thanks.
> > 
> > This part should go into Classpath; I'll handle that.
> > 
> > David> +++ sysdep/powerpc/locks.h	(working copy)
> > 
> > I don't know enough to review this bit.  I'm inclined to take your
> > word for it, though, unless Andrew wants to take a look.
> 
> It's kinda evil.  I guess the AIX assembler doesn't have local labels
> (which were invented in 1958 by M.E. Conway for the UNIVAC 1 assembler.
> Time to catch up, IBM!)
> 
> I suppose we'll live with it.

With inline asm, you could still use .Lppc_lock1st%= and .Lppc_lock2nd%=
or something similar.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]