This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libfortran] Bounds checking for transpose


Hello Thomas,

Thomas Koenig wrote:
> this rather self-explanatory patch adds bounds-checking for transpose.
> Regression-tested on x84_64-pc-linux-gnu.
>   
Thanks.

+       runtime_error ("Incorrect extent in return value of TRANSPOSE"
+                      "  intrinsic in dimension 2: is %ld,"
+                      " should %ld", (long int) src_extent,

a) As mentioned before by Andreas: You have a one extra space in the
string "<space><space>intrinsic..."
(in all four error messages in .m4)

b) I don't like "should 5"; how about either adding a "be" or using
"instead of" instead?, e.g.
"is 4, should be 5"
"is 4 instead of 5"
"4 instead of 5"

> OK for trunk?
>   
OK with the two changes.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]