This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;


Manuel López-Ibáñez wrote:

> OK to commit?

OK, with a minor change.  (No need for retesting.)

> +   This is a helper function of common_type and
> +   type_after_usual_arithmetic_conversions.  Probably you want to use
> +   one of those instead.  */

Drop this paragraph.  The first sentence is true now, but may not be in
future.  The second sentence is not helpful; there's no way to know what
the future developer "probably" wants.  Just say what the function does.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]