This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;


2008/8/29 Mark Mitchell <mark@codesourcery.com>:
> Manuel López-Ibáñez wrote:
>
>> 2008-08-26  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>>
>>       PR c++/37004
>> cp/
>
> The idea here is OK, but you need comments on every new function
> explaining each parameter, even if the original functions you're working
> from failed to conform to that requirement.  In particular,
> cp_common_type does not meet requirements.  Please resubmit with
> comments corrected.

Here is the update patch. The ChangeLog is the same as in the original.

Just in case, bootstrapped and regression tested on
x86_64-unknown-linux-gnu with
--enable-languages=all

OK to commit?

Cheers,

Manuel.

Attachment: fix-pr37004.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]