This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, libfortran] Bounds checking for spread
- From: Tobias Burnus <burnus at net-b dot de>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 15 Oct 2008 17:37:13 +0200
- Subject: Re: [patch, libfortran] Bounds checking for spread
- References: <1224006204.2933.5.camel@meiner.onlinehome.de>
Thomas Koenig wrote:
> Hello world,
>
> this patch completes bounds checking for spread. Regression-tested
> on i686-pc-linux-gnu. Regression-testing actually found a bug in the
> reshape_order_*.f90 test cases, so there :-)
>
> I won't have time to fix all array bounds issues with the array
> intrinsics for 4.4 as I had originally planned, but at least things are
> better than they were with 4.3.
>
> OK for trunk?
>
Looks OK. Thanks for the patch.
(Regarding the reshape_order_*.f90: They might have "bugs" but since
they are supposed to be invalid ... your check just comes earlier than
the one to be checked for ;-)
Tobias
> 2008-10-12 Thomas Koenig <tkoenig@gcc.gnu.org>
>
> PR libfortran/34670
> * intrinsics/reshape_generic.c: Add bounds checking.
> * m4/reshape.m4: Likewise.
> * generated/reshape_c10.c: Regenerated.
> * generated/reshape_c16.c: Regenerated.
> * generated/reshape_c4.c: Regenerated.
> * generated/reshape_c8.c: Regenerated.
> * generated/reshape_i16.c: Regenerated.
> * generated/reshape_i4.c: Regenerated.
> * generated/reshape_i8.c: Regenerated.
> * generated/reshape_r10.c: Regenerated.
> * generated/reshape_r16.c: Regenerated.
> * generated/reshape_r4.c: Regenerated.
> * generated/reshape_r8.c: Regenerated.
> * generated/spread_r4.c: Regenerated.
>
> 2008-10-12 Thomas Koenig <tkoenig@gcc.gnu.org>
>
> PR libfortran/34670
> * gfortran.dg/reshape_3.f90: New test.
> * gfortran.dg/reshape_4.f90: New test.
> * gfortran.dg/reshape_order_1.f90: Use correct shape.
> * gfortran.dg/reshape_order_2.f90: Likewise.
> * gfortran.dg/reshape_order_3.f90: Likewise.
> * gfortran.dg/reshape_order_4.f90: Likewise.
>
>