This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow -pg without frame pointer on x86


On Mon, Oct 13, 2008 at 07:08:44AM +0200, Paolo Bonzini wrote:
> Richard Guenther wrote:
> > On Sun, Oct 12, 2008 at 4:31 PM, Andi Kleen <andi@firstfloor.org> wrote:
> >>> Please move the testcase to gcc.target/i386 instead.  The patch looks ok,
> >> The test case itself is not really x86 specific by itself.
> >> I figured other architectures would eventually add some equivalent
> >> of this option (hopefully even the same name). Should I still move it?
> > 
> > Well, in this case, ok - just leave it.
> > 
> >>> but
> >>> how is your copyright assignment paperwork going?
> >> Hasn't gone through yet. I was somewhat hoping this patch would
> >> be still small enough to be done without?
> > 
> > This is definitely not small enough.  Small enough is 2 or 3 lines.
> 
> Agreed, but small enough is 10-15 lines according to FSF guidelines.

Thanks. That was my recollection too. Without test case/comments/docs
the patch is something like 25 changed lines.

-Andi

-- 
ak@linux.intel.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]