This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support Xilinx PowerPC single-precision FPU


Peter Bergner wrote:
On Thu, 2008-10-09 at 20:07 -0500, Peter Bergner wrote:
On Thu, 2008-10-09 at 17:10 -0700, Michael Eager wrote:
The attached replacement patch eliminates the duplicate definition.
I'm unclear why this only appeared when building with target=
powerpc64-linux and not with target=powerpc-eabisim.
Ok, I have kicked off another bootstrap/regtest.

It bootstrapped fine, but it seems the testsuite run missed some -m64 tests. It may have been due to my connection dropping to me build machine, so I'm kicking off the regtest again to be sure.

That said, this hunk looks like it's unneeded:

+enum fpu_type_t fpu_type = FPU_NONE;
+

fpu_type is only ever used within rs6000_handle_option(), so you
could just make it a local var.  You also don't need to initialize
it, since you always set it via rs6000_parse_fpu_option() before
using it.

I'll report back when my 2nd regtest is finished.

I'll submit a follow-up patch to move fpu_type within rs6000_handle_option() after your regression tests pass. Let me know if you see other problems.

Thanks!

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]