This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [vta] revamp bootstrap-debug with -fcompare-debug, fix LIBCFLAGS uses


On Oct  7, 2008, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:

>> for ChangeLog.vta
>> * libjava/configure.ac: Insert libgcjdir in the GCJ passed in the
>> environment, rather than overriding completely.
>> * libjava/configure: Rebuilt.

> Not in a separate ChangeLog file?

Yeah, I was lazy.  There wasn't a libjava/ChangeLog.vta yet, and I
didn't think it was worth it to create one for this change.  For sure
it would be moved to libjava/ChangeLog at merge time.

>> +libgcjdir=`${PWDCMD-pwd}`
>> +case $libgcjdir in
>> +*,*) libgcjdir=`echo "$libgcjdir" | sed 's:,:\\,:g'`;;
>> +esac

> Why was this escaping added?  It looks wrong.

Because libgcjdir is only used in a 's,,,' sed command a few lines
down, so for safety we need commas in it to be quoted.  Just in case
the user has commas in the build dir.

>> +  GCJ=`echo "$GCJ" | sed "s, -B, -B$libgcjdir/&,"`

Or at least that was the plan.  Now I see it may be used out of sed
commands too:

>> +  GCJ=$GCJ" -B$libgcjdir/"

In this case, the backslashes will probably be harmless, but I guess
it's worth fixing or commenting on.  Will do.  Thanks.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member       ÂSÃ Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]