This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR c++/27574


Dodji Seketeli wrote:
Jan, I did post a superset of Ian's patch to make the sanity check code not cry when it encounters abstract functions. Could you please tell if it looks okay to you so that I can push it to the released branches ? The post is at http://gcc.gnu.org/ml/gcc-patches/2008-09/msg01815.html.

s/comply/complain/


Now for the approach to use in trunk, there is something I am not sure about.

My understanding is that for each node which node->decl is abstract, we'd like to build a node->global->cloned_to list of nodes that points to the clones of the abstract node.
That'd allow the code of cgraph_remove_node() check for the presence of node->global->cloned_to list and not kill the body of the node if that list is present.

I think it would be better to do it the other way around; if a function we still need has DECL_ABSTRACT_ORIGIN, we need to keep the decl it points to. But again, I don't know the cgraph code.


Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]