This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libcpp] RFA: Add support for comments retrieval


>>>>> "Arnaud" == Arnaud Charlet <charlet@adacore.com> writes:

>> Is the patch OK with these changes ?

Arnaud> Appended for completeness.

I have two trivial nits.  It is ok with these changes.

Normally I would say that this should be delayed until Stage 1, but I
think it is reasonably small and safe, and so it can go in now.

Arnaud> 2008-09-26  Matthew Gingell  <gingell@adacore.com>
Arnaud> 	    Arnaud Charlet  <charlet@adacore.com>

Arnaud> 	* include/cpplib.h (cpp_comments, cpp_comment_table): New structs.
Arnaud> 	(cpp_get_comments): New function.

Arnaud> 	* internal.h (struct cpp_reader): Add comments field.

[...]

For a single change which spans multiple files, I don't put blank
lines between the file entries in the ChangeLog.

Arnaud> +	free (pfile->comments.entries [i].comment);

No space before the '['.  There are a couple cases of this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]