This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RESUBMIT: PowerPC -- support single-precision FPU


On Thu, Oct 2, 2008 at 3:23 PM, Michael Eager <eager@eagercon.com> wrote:

> I'm not sure that removing the test for TARGET_SINGLE_FLOAT
> in USE_FP_FOR_ARG_P is correct.  On a target with a single-precision
> FPU, only SFmode values can be passed in FP regs.  This change says
> that DFmode values are can be passed in FP regs, even if
> TARGET_DOUBLE_FLOAT is false.
>
> Removing the test in rs6000_function_value() means that
> FP_ARG_RETURN will be used to return all FP values.   That's
> not correct on a single-precision FPU for DFmode values.
>
> I'll admit to being confused about TFmode.  This seems to
> sneak in with DFmode.

I did not mean to imply that my patch was the final, correct implementation
for the Xilinx functionality.  I meant this returns GCC to correct behavior
for existing architectures and ABIs.

David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]