Re: [lto][patch] Simplify the lto-symtab api a bit

["Diego Novillo" <dnovillo at google dot com>]

On Wed, Oct 1, 2008 at 10:40, Rafael Espindola <espindola@google.com> wrote:

> -static void
> -global_vector_fixup (struct data_in *data_in, unsigned index, tree node)
> +static tree
> +global_vector_fixup (struct data_in *data_in, unsigned index)

The comment needs updating.  NODE doesn't exist anymore.

> -tree
> +void
>  lto_symtab_merge_var (tree new_var, enum ld_plugin_symbol_resolution resolution)
>  {
> -  return lto_symtab_merge_decl (new_var, resolution);
> +  lto_symtab_merge_decl (new_var, resolution);
>  }
>
> -tree
> +void
>  lto_symtab_merge_fn (tree new_fn, enum ld_plugin_symbol_resolution resolution)
>  {
> -  return lto_symtab_merge_decl (new_fn, resolution);
> +  lto_symtab_merge_decl (new_fn, resolution);
> +}
> +
> +tree
> +lto_symtab_canonical_decl (tree decl)
> +{
> +  return LTO_IDENTIFIER_DECL (DECL_ASSEMBLER_NAME (decl));
>  }

Since you're here, could you add comments to all these functions?
We have many that need commenting, but we can do this little by
little.

OK with those changes.


Thanks.  Diego.