This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR37583 - ICE "insert_bbt(): Duplicate key" for self-calling ENTRY subprogram

From: Tobias Burnus <burnus at net-b dot de>
To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sun, 21 Sep 2008 21:51:43 +0200
Subject: Re: [Patch, fortran] PR37583 - ICE "insert_bbt(): Duplicate key" for self-calling ENTRY subprogram
References: <20080920070826.GA7075@net-b.de> <339c37f20809210954l410dec14x36beef4e13b5bdf3@mail.gmail.com>

Paul Richard Thomas wrote:
>> OK. Thanks for the quick patch
> I realised that instead of adding a line as in:
>
>   		     && module_procedure
> - 		     && gfc_current_ns->proc_name->attr.function))
> + 		     && (gfc_current_ns->proc_name->attr.function
> + 			   || gfc_current_ns->proc_name->attr.subroutine)))
>
> elimination works just as well...
>
>     if (get_proc_name (name, &entry,
>   		     gfc_current_ns->parent != NULL
>   		     && module_procedure)
>   

Makes sense since everything which is a module_procedure should be
either a function or a subroutine. Just for completeness, the modified
patch is also OK.

Tobias

Follow-Ups:
- Re: [Patch, fortran] PR37583 - ICE "insert_bbt(): Duplicate key" for self-calling ENTRY subprogram
  - From: Paul Richard Thomas

References:
- Re: [Patch, fortran] PR37583 - ICE "insert_bbt(): Duplicate key" for self-calling ENTRY subprogram
  - From: Tobias Burnus
- Re: [Patch, fortran] PR37583 - ICE "insert_bbt(): Duplicate key" for self-calling ENTRY subprogram
  - From: Paul Richard Thomas

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]