This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA:] Fix PR37170 (and PR37280): weak-1.c regression, third edition
- From: Ian Lance Taylor <iant at google dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 17 Sep 2008 07:09:54 -0700
- Subject: Re: [RFA:] Fix PR37170 (and PR37280): weak-1.c regression, third edition
- References: <200809030219.m832Js5I003019@ignucius.se.axis.com>
Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:
> gcc/testsuite:
> PR middle-end/37170
> PR middle-end/37280
> * gcc.dg/weak/weak-15.c, gcc.dg/weak/weak-16.c,
> g++.dg/ext/inline1.C: New tests.
>
> gcc:
> PR middle-end/37170
> PR middle-end/37280
> * final.c (mark_symbol_ref_as_used): New helper function.
> (output_operand): Instead of just looking inside MEMs for
> SYMBOL_REFs, use new helper function and for_each_rtx.
> * varasm.c (assemble_external): Move #ifndef ASM_OUTPUT_EXTERNAL
> to after weak-handling. Don't mark decls with TREE_STATIC as weak.
> Make head comment more general.
> * config/darwin.c (machopic_output_indirection): Handle weak
> references here, like in assemble_external.
This is OK.
Thanks.
Ian