This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build


Danny Smith wrote:
On Tue, Sep 9, 2008 at 11:16 AM, Aaron W. LaFramboise
<aaronavay62@aaronwl.com> wrote:
Joseph S. Myers wrote:

The C front-end change is OK, but the rest will need MinGW maintainer
review and the MinGW maintainers will need to judge its suitability for
Stage 3.
I recommend Danny approve this for stage 3 because this is one of the last
things preventing --enable-werror builds from working, which is a valuable
feature.  It's also a bug, PR25502.


I really think that this is bit of an overkill and would prefer a more generic solution, eg fixing the bug "please provide a way to treat -pedantic as warning when using -Werror" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37187 or even including as part of -fms-extensions

In other words,  I am a bit concerned about adding YA MS-specific
feature at stage 3, just to allow --enable-werror builds.

This is an important flag for most any Windows code, that will need to use the 64-bit formatter, but where the developers would also desire to compile with -pedantic and be warning clean, which I think is an extremely reasonable request. Without this, -pedantic -Werror is not reasonably usable in Windows code that needs to print 64-bit integers.


Do you think this is sufficiently risky that it should be delayed to 4.5? Or would you prefer it be rolled into -fms-extensions?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]