This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, SPU] generated better code for loads and stores
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: Trevor_Smigiel at playstation dot sony dot com
- Cc: gcc-patches at gcc dot gnu dot org (gcc-patches), andrew_pinski at playstation dot sony dot com, rguenther at suse dot de
- Date: Fri, 12 Sep 2008 15:29:07 +0200 (CEST)
- Subject: Re: [PATCH, SPU] generated better code for loads and stores
Trevor,
> After split0 every address must satisfy LEGITIMATE_ADDRESS. I can't
> think of a test case off the top of my head, but it is better to be safe
> and make sure the address is valid. The code after this that changes
> the load to TImode forces it to be valid.
I had assumed that if the address passed the tests in spu_split_load
up to this point, and no rotate was required, the address *must* be
legitimate ... But in any case, adding a check certainly cannot hurt.
> Also, the floating point neg patterns might benefit from being split
> later.
>
> I'll merge your changes into my patch, retest and resubmit.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com