Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build

[Kai Tietz <Kai dot Tietz at onevision dot com>]

"Joseph S. Myers" <joseph@codesourcery.com> wrote on 08.09.2008 13:59:39:

> On Mon, 8 Sep 2008, Kai Tietz wrote:
> 
> > +Disables the warnings about none-ISO @code{printf} / @code{scanf} 
format
> 
> "non-ISO", not "none-ISO".
> 
> > +width specifiers @code{I32}, @code{I64}, and @code{I} used in 
> windows targets
> 
> "on Windows", not "in windows".
> 
> > +depending on the ms runtime, when you are using the option 
@option{-std=}
> 
> "MS", not "ms".
> 
> > +set an ISO standard without gnu-extensions, or the options 
> @option{-Wformat}
> > +and @option{-pedantic}.
> 
> This has nothing to do with -std, only -Wformat -pedantic.

I did the corrections to the documentation you mentioned and removed the 
ref to -std.

> The patch still lacks testcases for the new option.

2008-09-08  Kai Tietz  <kai.tietz@onevision.com>

        Fix PR/25502
        * c-format.c (convert_format_name_to_system_name): Use
        TARGET_OVERRIDES_FORMAT_INIT.
        * config.gcc (extra_options): Add for mingw targets mingw.opt.
        * config/i386/mingw.opt: New.
        * config/i386/mingw32.h (TARGET_OVERRIDES_FORMAT_INIT): New.
        * config/i386/msformat-c.c (TARGET_OVERRIDES_FORMAT_INIT): New.
        (ms_printf_length_specs): Removed const specifier.
        * doc/tm.texi (TARGET_OVERRIDES_FORMAT_INIT): New.
        * doc/invoke.texi (Wno-pedantic-ms-format): New.

2008-09-08  Kai Tietz  <kai.tietz@onevision.com>

        * testsuite/gcc.dg/format/ms-format1.c: New.


2008-09-08  Kai Tietz  <kai.tietz@onevision.com>

        * config/mh-mingw (BOOT_CFLAGS): Add -Wno-pedantic-ms-format

Ok for apply?

Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: mingw-ped-warning.txt
Description: Text document