This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: GTY as attribute(single patch)

From: Diego Novillo <dnovillo at google dot com>
To: Taras Glek <tglek at mozilla dot com>
Cc: Tom Tromey <tromey at redhat dot com>, Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 08 Sep 2008 07:41:26 -0400
Subject: Re: GTY as attribute(single patch)
References: <4875237C.308@mozilla.com> <m3vdze4r1f.fsf@fleche.redhat.com> <487666D7.8090306@codesourcery.com> <4877F5CD.90805@mozilla.com> <m3skub3xna.fsf@fleche.redhat.com> <487E4982.9010403@mozilla.com>

Taras Glek wrote:

2008-07-16  Taras Glek  <tglek@mozilla.com>
gcc/ChangeLog
  * gengtype-lex.l:  Removed GTY error check from lexer
  * gengtype-parse.c: Changed GTY placement on structs and unions
  * doc/gty.texi: Changed GTY placement in examples and mention attributes
  * ada/ada-tree.h: Update GTY annotations.
  * ada/trans.c: Likewise.
  * ada/utils.c: Likewise.
  * alias.c: Likewise.
  * basic-block.h: Likewise.
  * bitmap.h: Likewise.
  * c-common.h: Likewise.
  * c-decl.c: Likewise.
  * c-parser.c: Likewise.
  * c-pragma.c: Likewise.
  * c-tree.h: Likewise.
  * cfgloop.h: Likewise.
  * cgraph.h: Likewise.
  * config/i386/i386.c: Likewise.
  * config/i386/i386.h: Likewise.
  * coretypes.h: Likewise.
  * cp/cp-tree.h: Likewise.
  * cp/decl.c: Likewise.
  * cp/mangle.c: Likewise.
  * cp/name-lookup.c: Likewise.
  * cp/name-lookup.h: Likewise.
  * cp/parser.c: Likewise.
  * cp/pt.c: Likewise.
  * cp/rtti.c: Likewise.
  * cp/semantics.c: Likewise.
  * cp/typeck2.c: Likewise.
  * cselib.h: Likewise.
  * dbxout.c: Likewise.
  * dwarf2out.c: Likewise.
  * except.c: Likewise.
  * except.h: Likewise.
  * fixed-value.h: Likewise.
  * fortran/f95-lang.c: Likewise.
  * fortran/trans-intrinsic.c: Likewise.
  * fortran/trans-io.c: Likewise.
  * fortran/trans.h: Likewise.
  * function.c: Likewise.
  * function.h: Likewise.
  * integrate.c: Likewise.
  * java/builtins.c: Likewise.
  * java/decl.c: Likewise.
  * java/java-tree.h: Likewise.
  * java/jcf.h: Likewise.
  * java/lang.c: Likewise.
  * objc/objc-act.c: Likewise.
  * objc/objc-act.h: Likewise.
  * optabs.c: Likewise.
  * output.h: Likewise.
  * real.h: Likewise.
  * rtl.h: Likewise.
  * stringpool.c: Likewise.
  * tree-flow.h: Likewise.
  * tree-scalar-evolution.c: Likewise.
  * tree-ssa-address.c: Likewise.
  * tree-ssa-operands.h: Likewise.
  * tree.c: Likewise.
  * tree.h: Likewise.
  * varasm.c: Likewise.
  * varray.h: Likewise.
  * vec.h: Likewise.

include/ChangeLog
  * hashtab.h: Update GTY annotations.
  * splay-tree.h: Likewise.

libcpp/ChangeLog
  * include/cpp-id-data.h: Update GTY annotations.
  * include/cpplib.h: Likewise.
  * include/line-map.h: Likewise.
  * include/symtab.h: Likewise.

Taras


This patch is OK with me.  I like the idea of treating GTY markers as
attributes, makes maintenance easier.

I would like to see this patch in mainline, but I'm not sure if we can add it now (this is through no fault of your own, as you submitted this patch well inside Stage 1). But I would like the RMs to decide whether to incorporate it now or wait until next stage 1.

Diego.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]