This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] target/37283: Fix -fno-unit-at-a-time and -fno-toplevel-reorder handling
- From: Samuel Tardieu <sam at rfc1149 dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Paul Brook <paul at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Andrew Pinski <pinskia at gmail dot com>
- Date: Tue, 2 Sep 2008 22:44:03 +0200
- Subject: Re: [PATCH] target/37283: Fix -fno-unit-at-a-time and -fno-toplevel-reorder handling
- References: <20080829230112.26798.87632.stgit@dawn.rfc1149.net> <de8d50360808291624s121d079fmbb80e6416a72972c@mail.gmail.com> <2008-08-30-01-39-50+trackit+sam@rfc1149.net> <200808301404.34768.paul@codesourcery.com> <2008-08-30-15-36-44+trackit+sam@rfc1149.net> <2008-08-30-15-38-11+trackit+sam@rfc1149.net> <2008-08-30-15-48-30+trackit+sam@rfc1149.net> <6dc9ffc80809021211t1d73f5dbteb773e0dce5e8184@mail.gmail.com>
* H.J. Lu <hjl.tools@gmail.com> [2008-09-02 12:11:20 -0700]
| On Sat, Aug 30, 2008 at 6:48 AM, Samuel Tardieu <sam@rfc1149.net> wrote:
| > After the commit to arm.c, the patch needing approval (with Paul
| > suggested changes) is:
| >
| > gcc/
| > PR target/37283
| > * opts.c (decode_options): Move processing of -fno-unit-at-a-time
| > and -fno-toplevel-reorder after handle_options.
| >
|
| This patch may have caused:
|
| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37339
Indeed, it caused it. However, I am not sure whether the patch or
the test is incorrect: the presence of "var1_t" in the assembly
code is triggered by "-fno-toplevel-reorder" (before and after this
patch). Before this patch, "-fno-unit-at-a-time" was not causing
"-fno-toplevel-reorder" as it should, while it does after the patch.
Any hint?