This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c

From: "Richard Guenther" <richard dot guenther at gmail dot com>
To: "Rafael Espindola" <espindola at google dot com>
Cc: "Hans-Peter Nilsson" <hans-peter dot nilsson at axis dot com>, pinskia at gmail dot com, hp at bitrange dot com, gcc-patches at gcc dot gnu dot org, dnovillo at google dot com, "Jan Hubicka" <jh at suse dot cz>, "Jason Merrill" <jason at redhat dot com>
Date: Tue, 2 Sep 2008 15:43:43 +0200
Subject: Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
References: <38a0d8450809020526j331e34eai856199e106556eda@mail.gmail.com> <200809021242.m82Cgass022615@ignucius.se.axis.com> <84fc9c000809020610p67e761cehf968133343dee484@mail.gmail.com> <38a0d8450809020634v2fdd7484h9176ee893739c8f5@mail.gmail.com>

On Tue, Sep 2, 2008 at 3:34 PM, Rafael Espindola <espindola@google.com> wrote:
>> Actually - can someone re-post the patch that you want to be reviewed?
>> I am lost in this thread.
>
> Attached. I proposed to try to removed some of the calls to
> assemble_external in the FE. I started with the ones in C++ and was
> surprised to see no regressions on x86 and x86-64 by just removing
> them.

Ok, this needs approval by a C++ FE maintainer.  But Honza may
tell if this looks sane ;)

Thanks,
Richard.

> 2008-08-28  Rafael Espindola  <espindola@google.com>
>
>       * class.c (build_vtbl_ref_1): Don't call assemble_external.
>       * decl2.c (mark_used): Don't call assemble_external.
>       * init.c (build_vtbl_address): Don't call assemble_external.
>
>
>> Richard.
>>
>
> Cheers,
> --
> Rafael Avila de Espindola
>
> Google | Gordon House | Barrow Street | Dublin 4 | Ireland
> Registered in Dublin, Ireland | Registration Number: 368047
>

Follow-Ups:
- Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
  - From: Jason Merrill

References:
- Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
  - From: Rafael Espindola
- Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
  - From: Hans-Peter Nilsson
- Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
  - From: Richard Guenther
- Re: [RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]