This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Ada] PR ada/5911 Enable multilib build for Ada


> The following patch has been tested on x86_64-linux trunk
> with this patch to correct an unrelated dwarf2out.c Ada bootstrap issue:
> 
> http://gcc.gnu.org/ml/gcc-patches/2008-08/msg02353.html
> 
> Testing is currently not possible on sparc-solaris/linux because
> bootstrap for C is broken:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37279

Since builds are broken in several ways, I'd suggest waiting that things
stabilize, otherwise people won't be able to test your change independently and
detect related troubles easily.

> I will need help for testing and completing the TODO part to support
> more platforms, Eric volunteered for sparc and Joel for RTEMS.

Well, the most problematic platforms will likely be powerpc-*, since there
are lots of multilib variants for ppc, so testing should really be done on
a powerpc multilib target (RTEMS maybe ?) before committing this change.

> In both case the fix will be expanding the multilib TODO section with
> appropriate selection machinery, hopefully nothing too complicated even
> for non Ada developpers, as promised I'll help on any problem that comes
> up. I tested that --disable-multilib disables Ada multilib too.

What about make check ? Does it work now with multilibs ?

> 2008-08-31  Laurent Guerby  <laurent@guerby.net>
>             Paolo Bonzini  <bonzini@gnu.org>
> 	
> 	PR ada/5911
> 	* Makefile.in (all, install, mostlyclean, clean, distclean): Add
> 	multilib handling.
> 	* configure.ac: Add multilib handling.
> 	* configure: Regenerate.

This part is OK, assuming successful powerpc testing.

> 2008-08-31  Laurent Guerby  <laurent@guerby.net>
> 
>         PR ada/5911
> 	* gcc-interface/Makefile.in: Add multilib handling for x86_64.

Please replace 'TODO' with '???' which is the convention for incomplete
changes.

> 	* system-linux-sparc.ads (Storage_Unit, Word_Size, Memory_Size): Use
> 	Standard attributes.

This part is not OK as discussed previousely in the context of x86.
Instead, you need to set arch appropriately, as done on x86/x86-64

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]