This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 28 Aug 2008 16:53:04 -0700
- Subject: Re: PR c++/37004 Wconversion warns for short y = 0x7fff; short z = (short) x & y;
- References: <6c33472e0808261033j2fa7748ax81cf9e9a77380386@mail.gmail.com>
Manuel López-Ibáñez wrote:
> 2008-08-26 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
>
> PR c++/37004
> cp/
The idea here is OK, but you need comments on every new function
explaining each parameter, even if the original functions you're working
from failed to conform to that requirement. In particular,
cp_common_type does not meet requirements. Please resubmit with
comments corrected.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713