Re: [lto][patch] Serialize RESX_EXPR properly. Implement lang_hooks.make_addressable for lto1.

[Diego Novillo <dnovillo at google dot com>]

Bill Maddox wrote:
> On Tue, Aug 26, 2008 at 5:54 AM, Diego Novillo <dnovillo@google.com> wrote:
>
> > > +     /* FIXME lto: The operands should be gimplified at this
> > > +        point, so it should be safe just to call mark_addressable
> > > +        here.  Gimplification may keep language-specific checks
> > > +        in the langhook from working as expected.  These belong
> > > +        in the front-ends.  */
> > >       lang_hooks.mark_addressable (val);
> > Just call mark_addressable() here.
>
> This will make the langhook obsolete.  Should I remove it?
>
> > Any diagnostic messages should've been emitted by now.
>
> I believe the langhook, and its calls from stmt.c, are the only
> place where such diagnostics were ever attempted.  Nowhere
> else is the asm string parsed to determine which operands
> are having their addresses taken.

Hmm, interesting.  I'm not quite sure why this is being done so late. 
I'll have to dig a little bit.  Let's do something so you don't get 
stuck.  I want to get the merge out of the way, so for now I suggest 
that you commit with these comments in and I will look at removing the 
langhook later.  It's not a big issue for now.


Thanks.  Diego.