This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] limit commit message to 500 lines (was: Please, do not use the merged revisions log as the commit message when merging)


On Tue, Aug 26, 2008 at 8:36 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Tue, Aug 26, 2008 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Aug 26, 2008 at 7:18 AM, Manuel López-Ibáñez
>> <lopezibanez@gmail.com> wrote:
>>> 2008/8/16 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>>>> Could we put a limit to the commit log entry? More than 500 hundred
>>>> lines changelog entries should just be rejected and this will avoid
>>>> someone accidentally committing a full log or a diff or just random
>>>> junk.
>>>>
>>>
>>> The following patch to our pre-commit hook enables this. I have tested
>>> it with a dummy repository but review from bourne-shell and/or
>>> subversion knowledgeable people would be welcome.
>>>
>>
>> When I add 600 testcases, should I mention each of them in commit log?
>
> Yes.
>
> IMHO 600 lines is too short.  Can't we simply detect svnmerge logs somehow?
>

Shouldn't svnmerge be fixed not to generate such log?


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]