This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Graphite review, graphite parts [1/n]
On Thu, 21 Aug 2008, Sebastian Pop wrote:
> Hi,
>
> On Thu, Aug 21, 2008 at 5:39 PM, Sebastian Pop <sebastian.pop@amd.com> wrote:
> > I will diff again the graphite branch against trunk and prepare the
> > split patches such that it will be simpler for you to review all the
> > changes.
>
> Attached are the middle-end changes from the graphite branch. You can
> get the graphite.[ch] files from:
> http://gcc.gnu.org/viewcvs/branches/graphite/gcc/graphite.c?view=markup
> http://gcc.gnu.org/viewcvs/branches/graphite/gcc/graphite.h?view=markup
>
> Build and testsuite parts are not included as I got an ok from
> maintainers for these parts.
The attached middle-end changes are ok. I believe the graphite.c
parts are still changing quite often on the branch, but the changes
you did addressed my previous reviews comments. So from my point of
view the graphite.[ch] changes are ok as well.
I think the graphite branch is ready for merging if the merge passes
bootstrapping and testing with graphite disabled (which is the default
state, right?) - this means it would not break on any host/target.
But I also think I cannot approve the merge itself - Mark, are you
fine with the current state and can you approve the merge with the
above conditions?
Thanks,
Richard.