This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RFA: Remove automatic enabling of gas cfi directives with an in-source-tree assembler
- From: Nick Clifton <nickc at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, rth at redhat dot com
- Date: Sun, 17 Aug 2008 18:25:20 +0100
- Subject: RFA: Remove automatic enabling of gas cfi directives with an in-source-tree assembler
Hi Guys,
The recent patches that support for the GAS CFI directives has a
problem in that the configure file enables this feature if the
target is built with an in-tree set of gas sources from release
2.17 or newer of the binutils. This is a problem, because the gas
cfi directives are only enabled on a per-target basis in the
assembler and not all targets currently support them, even in the
very latest sources. (Eg Vax, MN10300).
The attached patch removes the assembler version check from the "cfi
directive" and "cfi personality directive" checks so that configure
will always perform an actual test of the assembler's capabilities.
Checked without regressions building an mn10300-elf toolchain as
well as an x86_64-pc-linux-gnu native toolchain in a combined
gcc/gdb/binutils source tree.
May I apply this patch please ?
Cheers
Nick
gcc/ChangeLog
2008-08-17 Nick Clifton <nickc@redhat.com>
* configure.ac (HAVE_GAS_CFI_DIRECTIVE): Always test for assembler
support of this feature. Do not assume that a sufficiently new
assembler will support the feature regardless of the target type.
(HAVE_GAS_CFI_PERSONALITY_DIRECTIVE): Likewise.
* configure: Regenerate.
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac (revision 139178)
+++ gcc/configure.ac (working copy)
@@ -2182,7 +2182,7 @@
# Check if we have assembler support for unwind directives.
gcc_GAS_CHECK_FEATURE([cfi directives], gcc_cv_as_cfi_directive,
- [elf,2,17,0],,
+ ,,
[ .text
.cfi_startproc
.cfi_offset 0, 0
@@ -2195,7 +2195,7 @@
[Define 0/1 if your assembler supports CFI directives.])
gcc_GAS_CHECK_FEATURE([cfi personality directive],
- gcc_cv_as_cfi_personality_directive, [elf,2,17,0],,
+ gcc_cv_as_cfi_personality_directive, ,,
[ .text
.cfi_startproc,
.cfi_personality 0, symbol