This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c++/35635 -Wconversion problematic with bitfields
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 12 Aug 2008 13:14:53 -0700
- Subject: Re: PR c++/35635 -Wconversion problematic with bitfields
- References: <6c33472e0808120750u46f5c6d3t422aa87c22875b48@mail.gmail.com>
- Reply-to: janis187 at us dot ibm dot com
On Tue, 2008-08-12 at 16:50 +0200, Manuel LÃpez-IbÃÃez wrote:
> 2008/8/12 Joseph S. Myers <joseph@codesourcery.com>:
> > On Tue, 5 Aug 2008, Manuel LÃpez-IbÃÃez wrote:
> >
> >> 2008-08-05 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
> >>
> >> PR 35635
> >> * c-common.c (conversion_warning): Use a switch. Ignore boolean
> >> expressions except for conversions to signed:1 bitfields. Handle
> >> COND_EXPR with constant operands.
> >>
> >> testsuite/
> >> * gcc.dg/pr35635.c: New.
> >> * gcc.dg/Wconversion-integer.c: Update.
> >> * gcc.dg/Wconversion-integer-no-sign.c: Update.
> >> * gcc.dg/Wsign-conversion.c: Update.
> >
> > The C testcases and the substantive parts of the c-common.c patch are OK.
>
> So only the C++ testcases need review...
They're fine.
Janis