This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Reserve the attributes for member function pointer type

From: Mark Mitchell <mark at codesourcery dot com>
To: Bo Yang <techrazy dot yang at gmail dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 06 Aug 2008 11:57:20 -0700
Subject: Re: PATCH: Reserve the __attributes__ for member function pointer type
References: <a47d5c0807302107o6ce10a99n3048aa004faee3f7@mail.gmail.com> <48914B88.10201@gnu.org> <a47d5c0807302327k57d9f97fs423ab81bcca608a2@mail.gmail.com> <20080731074327.GI8133@devserv.devel.redhat.com> <a47d5c0807310118h1a11113cs2dac1a6348460fe5@mail.gmail.com> <20080731083108.GJ8133@devserv.devel.redhat.com> <a47d5c0807310154h349556e5qf5a9df98f1dd71ad@mail.gmail.com>

Bo Yang wrote:

   fntype = build_method_type_directly (ctype, TREE_TYPE (fntype),
 				       (TREE_CODE (fntype) == METHOD_TYPE
 					? TREE_CHAIN (TYPE_ARG_TYPES (fntype))
 					: TYPE_ARG_TYPES (fntype)));
+  TYPE_ATTRIBUTES (fntype) = attr;

This is not OK as build_method_type_directly may return an existing METHOD_TYPE. To fix this, you'll need look at how we handle attributes on FUNCTION_TYPE and replicate that kind of logic for METHOD_TYPE.

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Follow-Ups:
- Re: PATCH: Reserve the __attributes__ for member function pointer type
  - From: Bo Yang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: PATCH: Reserve the __attributes__ for member function pointer type

Re: PATCH: Reserve the attributes for member function pointer type