This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -H vs. PCH (PR preprocessor/36649)
- From: Tom Tromey <tromey at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 30 Jul 2008 09:31:17 -0600
- Subject: Re: [PATCH] Fix -H vs. PCH (PR preprocessor/36649)
- References: <20080730152451.GD8133@devserv.devel.redhat.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Jakub> The following patch fixes it by saving/restoring the
Jakub> line_table-> trace_includes
Jakub> setting around PCH reading, similarly how e.g. location is saved.
It looks good to me -- though I can't approve patches in c-pch.c.
I have occasionally wondered why this work is done here and not in
cpp_read_state. However, given that there is already code in c-pch.c
to save and restore something, I think it doesn't hurt to add more.
Tom