This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ada: Accept escaped '(' in a regular expression '()' group


> | There is indeed a bug in GNAT.Regexp, and your fix is good.
> | However, it seems a bit inefficient because it requires an array the
> | size of the string, which I think is unnecessary.
> | We only need to check whether the last opening parenthesis was the
> | previous character. Nested parenthesis are automatically handled (if
> | the one inside is not empty, then the outer one cannot be empty either)
> | 
> | I propose the following patch instead:
> 
> Looks fine with me. Arnaud, will you take care of it?

I can take care of it as part of regular submissions, although due to various
build failures recently (and being on vacation before that), I have some
back log, so won't get into it right away. I guess there's no real urgency
in any case.

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]