This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, spu]: support context-sensitive keywords
- From: Tom Tromey <tromey at redhat dot com>
- To: "Andrew Pinski" <Andrew_Pinski at playstation dot sony dot com>
- Cc: "Ben Elliston" <bje at au1 dot ibm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "Ulrich Weigand" <uweigand at de dot ibm dot com>, Trevor_Smigiel <Trevor_Smigiel at playstation dot sony dot com>
- Date: Wed, 23 Jul 2008 09:04:49 -0600
- Subject: Re: [PATCH, spu]: support context-sensitive keywords
- References: <1216775435.31101.6.camel@helios> <de8d50360807221840oa59017fw2a7f447057e91a32@mail.gmail.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Andrew" == Andrew Pinski <Andrew_Pinski@playstation.sony.com> writes:
>> +/* Keep the vector keywords handy for fast comparisons. */
>> +static tree __vector_keyword;
>> +static tree vector_keyword;
Andrew> I think you need a GTY(()) on those variables, otherwise you will end
Andrew> up with the identifiers getting lost, maybe (I forget when identifiers
Andrew> are GCable, Tom?).
They are GCable any time after the parse_file langhook has returned.
See toplev.c:compile_file().
Thanks for noticing this -- this was the whole reason to move from
hash nodes to identifiers here :)
Tom