This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [middle-end, patch 5/8] Create ipa-prop structures when performing indirect inlining


Hi,

On Tue, Jul 15, 2008 at 11:23:59PM +0200, Ralf Wildenhues wrote:
> Hello,
> 
> this is not an approval, nor a full review.
> 
> * Martin Jambor wrote on Tue, Jul 15, 2008 at 09:43:52PM CEST:
> > 
> > 2008-07-15  Martin Jambor  <mjambor@suse.cz>
> > 
> > 	* ipa-inline.c: Include ipa-prop.h.
> 
> You adjust Makefile.in but do not note it in the ChangeLog entry.

I have added

  * Makefile.in (ipa-inline.o): Added $(IPA_PROP_H) to dependencies.

> > 	(inline_indirect_intraprocedural_analysis): New function.
> > 	(inline_generate_summary): Allocate parameter and argument info
> > 	structures, call inline_indirect_intraprocedural_analysis on each
> > 	node when doing indirect inlining and deallocate indirect inlining 
> > 	data structures in the end.
> > 
> 
> Superfluous empty line again. 

Removed.

> The previous paragraph is probably a bit
> verbose for GCC standards, dunno.

It describes three distinct changes. 

Thanks,

Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]