Re: (new) Failure building GFortran (Cygwin)

["Raksit Ashok" <raksit at google dot com>]

On Fri, Jul 11, 2008 at 1:09 AM, Angelo Graziosi
<angelo.graziosi@alice.it> wrote:
> Gabriel Dos Reis ha scritto:
>>
>> On Tue, Jul 8, 2008 at 3:48 AM, Angelo Graziosi
>> <> wrote:
>>>
>>> Ian Lance Taylor ha scritto:
>>>>
>>>> This is OK, with a ChangeLog entry, if it passes bootstrap with the
>>>> appropriate configure option.
>>>
>>> The following bootstraps rev. 137613, having configured as
>>>
>>> ${gcc_dir}/configure --prefix="${prefix_dir}" \
>>>                        --exec-prefix="${eprefix_dir}" \
>>>                        --sysconfdir="${sysconf_dir}" \
>>>                        --libdir="${lib_dir}" \
>>>                        --libexecdir="${libexec_dir}" \
>>>                        --mandir="${man_dir}" \
>>>                        --infodir="${info_dir}" \
>>>                        --enable-languages=c,fortran \
>>>                        --enable-bootstrap \
>>>                        --enable-decimal-float=bid \
>>>                        --enable-libgomp \
>>>                        --enable-threads \
>>>                        --enable-sjlj-exceptions \
>>>                        --enable-version-specific-runtime-libs \
>>>                        --enable-nls \
>>>                        --enable-checking=release \
>>>                        --disable-fixed-point \
>>>                        --disable-libmudflap \
>>>                        --disable-shared \
>>>                        --disable-win32-registry \
>>>                        --with-system-zlib \
>>>                        --without-included-gettext \
>>>                        --without-x
>>>
>>> ===========================================================
>>> gcc/ChangeLog:
>>> 2008-07-08  Angelo Graziosi  <>
>>>
>>>
>>>       * ggc-page.c (alloc_page):
>>>       Substituting xmalloc, xcalloc with
>>>       XNEWVEC and XCNEWVAR macros which add the
>>>       needed casts.
>>>
>>>
>>>
>>> --- gcc.orig/gcc/ggc-page.c  2008-06-29 06:39:16.000000000 +0200
>>> +++ gcc/gcc/ggc-page.c       2008-07-08 09:00:20.906250000 +0200
>>> @@ -799,7 +799,7 @@
>>>       alloc_size = GGC_QUIRE_SIZE * G.pagesize;
>>>      else
>>>       alloc_size = entry_size + G.pagesize - 1;
>>> -      allocation = xmalloc (alloc_size);
>>> +      allocation = XNEWVEC (char, alloc_size);
>>
>> OK.
>>
>>>      page = (char *) (((size_t) allocation + G.pagesize - 1) &
>>> -G.pagesize);
>>>      head_slop = page - allocation;
>>> @@ -842,7 +842,7 @@
>>>         struct page_entry *e, *f = G.free_pages;
>>>         for (a = enda - G.pagesize; a != page; a -= G.pagesize)
>>>           {
>>> -             e = xcalloc (1, page_entry_size);
>>> +             e = XCNEWVAR (struct page_entry, page_entry_size);
>>
>> OK.
>>
>>
>>>             e->order = order;
>>>             e->bytes = G.pagesize;
>>>             e->page = a;
>>> ===========================================================
>
> If the patch is OK, may someone apply/commit it so we can test it also with
> the next 4.4 snapshot?

Committed on Angelo's behalf as revision 137722. (I was running into
the same build failure on cygwin, and I validated that this patch
fixes the build failure and it bootstraps on i686-pc-cygwin and
i686-linux).

Thanks,
Raksit



>
>
> Thanks,
>   Angelo.
>
> ---
> Pace è gioia!
>
>