This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] PR 31754/C++ - make -fshow-column produce more accurate column numbers
- From: Dodji Seketeli <dseketel at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 10 Jul 2008 15:02:19 +0200
- Subject: Re: [patch] PR 31754/C++ - make -fshow-column produce more accurate column numbers
- References: <485B82BD.9050202@redhat.com> <m34p7itl1q.fsf@fleche.redhat.com> <48639BB1.6050409@redhat.com> <4863E1F8.3010408@redhat.com> <486B5612.9090400@redhat.com> <48758655.5020705@redhat.com>
Jason Merrill a écrit :
Dodji Seketeli wrote:
+/// in the coming test, the column information is broken as it points to
+// the end of the declaration instead of pointing to the begining of
the
+// 'TYPE' identifier. This is due to the warning being generated by the
+// declaration groking code (gcc/cp/decl.c) and not the parser. So
in that
+// code, the exact token location information is lost as the
declaration
+// groking code manipulates TREEs only.
grokdeclarator takes a cp_declarator *, and cp_declarator has a
location_t field. The comment says "Currently only set for cdk_id", but
surely that could change.
Right. I will look into that.
But that doesn't seem like a reason to hold up this patch; go ahead and
check this in and fix that in another patch.
Okay, thanks very much. I don't have the commit access to the
repository, so I cannot commit.
Dodji.