This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto][patch] Stream missing fields in FUNCTION_DECL causing builtins to break
- From: Diego Novillo <dnovillo at google dot com>
- To: Bill Maddox <maddox at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Jun 2008 18:44:43 -0400
- Subject: Re: [lto][patch] Stream missing fields in FUNCTION_DECL causing builtins to break
- References: <8a0e66f0806271537r14220b86oe24409fd667577d8@mail.gmail.com>
On Fri, Jun 27, 2008 at 18:37, Bill Maddox <maddox@google.com> wrote:
> This patch fixes about half of the current streamer failures on the C
> test suite:
>
> * lto-function-out.c (output_function_decl):
> Write function_code and built_in_class fields.
> * lto-function-in.c (input_function_decl):
> Read function_code and built_in_class fields.
I guess the failure here was forgetting to stream DECL_BUILTIN_CODE
and such? Could we conditinalize this in DECL_IS_BUILTIN?
I'm not sure, though. When reading in the function in
input_function_decl we may not have enough to recognize whether the
decl is a builtin (we use DECL_SOURCE_LOCATION for that).
If it can't be easily conditionalized, then this is OK.
Diego.