This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto][patch] remove local variables from types (after gimplification)
2008/6/24 Richard Guenther <richard.guenther@gmail.com>:
> On Mon, Jun 23, 2008 at 4:43 PM, Rafael Espindola <espindola@google.com> wrote:
> This works for me. Note that if either TYPE_SIZE_UNIT or
> TYPE_SIZE is NULL, both should be.
Will try to add that.
> Also the same handling
> of TYPE_MAX_VALUE should apply to TYPE_MIN_VALUE - and
> rather than setting them to zero I would suggest to set them to
> the types natural bounds based on its precision.
Any objections to have that semantics with NULL? Will try to add it to
TYPE_MIN_VALUE.
> And it looks like
> you miss TYPE_DOMAIN of ARRAY_TYPE, which contains
> the variable bounds of an array.
The callback gets passed all types. In particular, it gets passed the
TYPE_DOMAIN and we clean up the TYPE_MAX_VALUE of it. I did try
setting the TYPE_DOMAIN to NULL but found many places that assume it
is not NULL.
> Richard.
Thanks,
--
Rafael Avila de Espindola
Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland
Registered in Dublin, Ireland
Registration Number: 368047